chore: standardize on modern Node and fix vue-tsc to run on it#39
Merged
Conversation
The repo pinned three different Node versions: .nvmrc (20.11.1), CI (22),
and package.json engines (>=24.13.0). No single version could run the whole
toolchain — eslint 9 needs Node 21+ (Object.groupBy) while vue-tsc 2.2.x
crashed on Node 22+ loading the vue-router volar plugin
("plugin is not a function").
- upgrade vue-tsc 2.2.x -> 3.3.5 (and @vue/language-core), which loads the
volar plugins correctly under modern Node
- remove unnecessary defineProps/defineEmits/defineExpose imports from
<script setup> (vue-tsc 3 correctly flags these compiler macros as
TS2440 import-conflicts; they were never needed)
- pin .nvmrc to 24.13.0 to match the engines field
- bump CI (unit-tests-ci.yml) from Node 22 to 24
With these changes the full toolchain (eslint, vue-tsc, vitest) runs green
on a single modern Node, so the pre-commit hook works again.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The repo pinned three different Node versions —
.nvmrc(20.11.1), CI (22), andpackage.jsonengines (>=24.13.0) — and no single version could run the whole toolchain:Object.groupBy).plugin is not a function).This standardizes everything on Node 24 and upgrades
vue-tscso the full toolchain (eslint + vue-tsc + vitest) runs green on one modern Node — and the pre-commit hook works again.Changes
vue-tsc2.2.x → 3.3.5 (and@vue/language-core), which loads the volar plugins correctly under modern Node.defineProps/defineEmits/defineExposeimports from 13<script setup>files (vue-tsc 3 correctly flags these compiler macros asTS2440import-conflicts; they were never needed)..nvmrcto 24.13.0 (matches theenginesfield).unit-tests-ci.yml) from Node 22 → 24.Verification (all on Node 24)
vue-tsc --noEmit: 0 errors.eslint: 0 errors (295 pre-existing warnings).vitest run: 1681 passing.Notes
Resolve plugin path failed: vue-router/volar/sfc-route-blocks(that plugin only handles<route>SFC blocks). tsc still exits 0.Map.specconstructor mocks,useAlbumImageUploadwindow.alert) fail on Node 20 but pass on Node 24 — another reason to standardize.🤖 Generated with Claude Code